Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Mini Wallet #23

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Support Mini Wallet #23

merged 9 commits into from
Aug 5, 2024
+71 −69

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Aug 2, 2024 •
edited
Loading

This PR contains the following changes:

  • Remove LIFF flag - This flag is no longer required.
  • Always dispaly QR code
  • Disable opening wc scheme link on opening authentication popup
  • Make default scheme native on opening wallets - I don't know why but universal link can't open confirmation view on Metamask.
  • Fix _convertToWcUri - This function returned invalid uri ('metamask:///wc?url=xxxx', three slashes is invalid).
  • Add Mini Wallet info
  • Support Mini Wallet browser

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-23--flutter-bird.netlify.app

@github-actions github-actions bot temporarily deployed to Netlify Preview August 2, 2024 11:20 Inactive
@ulbqb
Copy link
Member Author

ulbqb commented Aug 2, 2024

Demo on Mini Wallet browser:

Screen.Recording.2024-08-02.at.20.26.51.mov

@shiki-tak
Copy link

I thought the purpose of this PoC was to create a dapp using LIFF, but is the LIFF flag unnecessary? After this, we can proceed with the task of checking what can be done using the LIFF API for additional research, etc.

@ulbqb
Copy link
Member Author

ulbqb commented Aug 5, 2024 •
edited
Loading

@shiki-tak
I think this project doesn't use LIFF feature despite of importing LIFF package. And we found that it's not needed to use LIFF in dApps.

@shiki-tak
Copy link

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

@ulbqb
Copy link
Member Author

ulbqb commented Aug 5, 2024

@shiki-tak

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

QR is needed if it's in PC but it's not easy to distinguish if it's PC browser view or mobile browser view.

@shiki-tak
Copy link

@shiki-tak

Why do you have the QR code visible all the time? I don't think it looks very visually appealing.

QR is needed if it's in PC but it's not easy to distinguish if it's PC browser view or mobile browser view.

@ulbqb
This is the code I committed last week. Is it possible to do this using this?
shiki-tak@a11da6f

@ulbqb
Copy link
Member Author

ulbqb commented Aug 5, 2024

@shiki-tak
Thank you. I'll try it.

@ulbqb ulbqb requested a review from Mdaiki0730 August 5, 2024 06:01
@github-actions github-actions bot temporarily deployed to Netlify Preview August 5, 2024 06:03 Inactive
@ulbqb ulbqb requested review from shiki-tak and da1suk8 August 5, 2024 06:22
@ulbqb ulbqb requested a review from Mdaiki0730 August 5, 2024 06:57
@ulbqb ulbqb merged commit 3cd8fe9 into master Aug 5, 2024
2 checks passed
@ulbqb ulbqb deleted the feat/mini_wallet branch August 5, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mdaiki0730 Mdaiki0730 Mdaiki0730 approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

@da1suk8 da1suk8 Awaiting requested review from da1suk8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ulbqb @shiki-tak @Mdaiki0730 @da1suk8